Set rels index for slide layouts #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progi1984
reviewed
Jul 6, 2021
Progi1984
reviewed
Jul 6, 2021
|
@Progi1984 Thanks for your feedback. I have changed it. |
Progi1984
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the change #637 we get an error with SlideLayouts:
PhpOffice\PhpPresentation\Slide\AbstractSlide::getRelsIndex(): Return value must be of type string, null returned.It seems that
relsIndexis not set for SlideLayouts and remains null. By adjusting the return type it does not work now. The method is used in:PhpOffice\PhpPresentation\Writer\PowerPoint2007\PptSlideLayouts::67It can be fixed by setting
relsIndexinPhpOffice\PhpPresentation\Writer\PowerPoint2007\ContentTypes::75