Skip to content

#634 : Enable PHPCSFixer #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Conversation

Progi1984
Copy link
Member

No description provided.

@Progi1984 Progi1984 added this to the 1.0.0 milestone Jun 6, 2021
@Progi1984 Progi1984 self-assigned this Jun 6, 2021
@Progi1984 Progi1984 linked an issue Jun 6, 2021 that may be closed by this pull request
11 tasks
@Progi1984 Progi1984 merged commit 8db2fd5 into PHPOffice:develop Jun 7, 2021
@Progi1984 Progi1984 deleted the issue634_next branch June 7, 2021 07:03
@Progi1984 Progi1984 mentioned this pull request Jun 7, 2021
11 tasks
@Brenneisen
Copy link
Contributor

Brenneisen commented Jul 1, 2021

@Progi1984 Due to the change we get an error with SlideLayouts:

PhpOffice\PhpPresentation\Slide\AbstractSlide::getRelsIndex(): Return value must be of type string, null returned.

It seems that relsIndex is not set for SlideLayouts and remains null. By adjusting the return type it does not work now. The method is used in:

PhpOffice\PhpPresentation\Writer\PowerPoint2007\PptSlideLayouts::67

I guess it can be fixed by setting relsIndex in

PhpOffice\PhpPresentation\Writer\PowerPoint2007\ContentTypes::75

like

$oSlideLayout->setRelsIndex((string) $oSlideLayout->layoutNr = ++$sldLayoutNr);

@Brenneisen
Copy link
Contributor

@Progi1984 I have created a PR for it: #646

@Brenneisen
Copy link
Contributor

@Progi1984 Could you please merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Roadmap for new version
2 participants