Skip to content

Improve CI settings #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2024
Merged

Improve CI settings #884

merged 3 commits into from
Jun 4, 2024

Conversation

takaram
Copy link
Contributor

@takaram takaram commented Jun 1, 2024

This PR includes some improvements about CI settings.

  • Use the latest version of actions/checkout and actions/cache
  • Remove PHP8.1-specific step on composer install
  • Paslm has output format setting for GtiHub Actions, so use it to remove cs2pr

@mnapoli
Copy link
Member

mnapoli commented Jun 2, 2024

Remove PHP8.1-specific step on composer install

Can you explain why?

@takaram
Copy link
Contributor Author

takaram commented Jun 3, 2024

@mnapoli
The step seems to have been there because ocramius/proxy-manager was unable to be installed on PHP 8.1.
See #808 (comment)

Now ocramius/proxy-manager was removed from composer.json in d2b57ec, and we see no problems without --ignore-platform-req, so let's make the job simpler.

@mnapoli
Copy link
Member

mnapoli commented Jun 4, 2024

ahh ok thanks!

@mnapoli mnapoli merged commit f50ab28 into PHP-DI:master Jun 4, 2024
@takaram takaram deleted the patch-1 branch June 4, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takaram @mnapoli