Fix public readonly property injection #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
approved these changes
Aug 8, 2023
4b2908b to
15e4b16
Compare
|
Done! The one remaining CS issue seems unrelated to my changes 🤔 |
|
Got it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler tries to initialize all public properties directly inside the compiled container, however readonly properties do not support writing from an outside scope.
Additionally, I noticed a small room for a performance improvement:
ReflectionProperty::setAccessible()doesn't have to be invoked as of PHP 8.1 (https://wiki.php.net/rfc/make-reflection-setaccessible-no-op), so I fixed it as well in a separate commit.