chore: PhpUnitDedicateAssertFixer - improve code for phpstan
#9011
Conversation
| } while ($tokens[$classEndIndex]->isGivenKind([\T_STRING, \T_NS_SEPARATOR, \T_VARIABLE])); | ||
|
|
||
| if ($tokens[$classEndIndex]->equalsAny([',', ')'])) { // do the fixing | ||
| array_pop($classPartTokens); |
There was a problem hiding this comment.
didn't this change the logic? we did array_pop + reset, now we do only reset. is reset changing anything now ?
There was a problem hiding this comment.
reset gives the first array element.
With array_pop we removed the last element, because we always added one "wrong" last element to the list in do-while-loop.
Caused by the array_pop call phpstan wasn't sure that the list is non-empty. So it complained about the reset() call, which could return false for empty list.
By changing the lines in do-while-loop I avoid the wrong last element. So we do not have to remove it anymore by array_pop. This helps phpstan to understand that $classPartTokens can not be empty, so that calling reset is safe and always will return an element (the first one).
There was a problem hiding this comment.
I meant that while we no longer manipulate the array with array_pop, the reset sounds superfluous (we do not rely on moving internal pointer)
No description provided.