chore: apply (partially) multiline_string_to_heredoc
#9002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gharlan
commented
Sep 1, 2025
| @@ -33,10 +33,16 @@ public function getDefinition(): FixerDefinitionInterface | |||
| { | |||
| return new FixerDefinition( | |||
| 'If the function explicitly returns an array, and has the return type `iterable`, then `yield from` must be used instead of `return`.', | |||
| [new CodeSample('<?php function giveMeData(): iterable { | |||
There was a problem hiding this comment.
In those cases I manually added newlines after the changes of the fixer.
| @@ -120,33 +120,48 @@ public function getDefinition(): FixerDefinitionInterface | |||
| 'Ordering `use` statements.', | |||
| [ | |||
| new CodeSample( | |||
| "<?php\nuse function AAC;\nuse const AAB;\nuse AAA;\n" | |||
| <<<'PHP' | |||
There was a problem hiding this comment.
The fixer didn't change these oneliners. I converted some of them manually.
| +sample(); $test = 1; | ||
| +sample(); $test = 2; | ||
| +for ( ; ; ++$sample) { | ||
| } |
There was a problem hiding this comment.
You can see that the string content of the samples didn't changed because the generated doc files didn't changed.
Only exception was this sample here where I changed the indentation intentionally..
multiline_string_to_heredoc
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.