chore: Tokens
- override nullability of SplFixedArray
#9001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SplFixedArray
usesT|null
in return types because value can be null if an offset is unset or if the size does not match the number of elements. (https://github.com/phpstan/phpstan-src/blob/c5d7128a8183efd61e73558626faf549e52db65a/stubs/ArrayObject.stub#L91-L93)But our
Tokens
class takes care of it and always ensures correct size and indexes, so that these methods never returnnull
instead ofToken
.So I suggest to override these return types.
At the moment it resolves only some ignored errors. But in higher PHPStan level it would resolve 342 new errors.