chore: use get_debug_type and ::class in exception messages
#9006
Conversation
| @@ -998,7 +998,7 @@ private static function separatedContextLessInclude(string $path): ConfigInterfa | |||
|
|
|||
| // verify that the config has an instance of Config | |||
| if (!$config instanceof ConfigInterface) { | |||
| throw new InvalidConfigurationException(\sprintf('The config file: "%s" does not return a "PhpCsFixer\ConfigInterface" instance. Got: "%s".', $path, \is_object($config) ? \get_class($config) : \gettype($config))); | |||
There was a problem hiding this comment.
i think you can update all usages of is_object
There was a problem hiding this comment.
In many cases we add the value for scalar types, e.g. "string#foobar":
There was a problem hiding this comment.
In some cases with additional null check:
in other cases with additional resource check:
Should we maybe add a helper method somewhere which handles all these cases?
And it could return nicer outputs like got string "foobar" instead of got "string#foobar",
There was a problem hiding this comment.
In many cases we add the value for scalar types, e.g. "string#foobar"
sounds OK, we can unify towards this direction
handle null...
OKish to have it unified, would produce NULL#, or we can have helper method as you suggested
There was a problem hiding this comment.
Would it be ok to merge this one as-is and have a look to the unification another time?
There was a problem hiding this comment.
sure, feel free to create a ticket for that
No description provided.