-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs: update README.md
and CONTRIBUTING.md
#8974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -27,7 +27,7 @@ projects. This tool does not only detect them, but also fixes them for you. | |||
* PHP 8.3 | |||
* PHP 8.4 | |||
|
|||
> **Note** | |||
> [!NOTE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -40,7 +40,7 @@ projects. This tool does not only detect them, but also fixes them for you. | |||
|
|||
The recommended way to install PHP CS Fixer is to use [Composer](https://getcomposer.org/download/): | |||
|
|||
```console | |||
```sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or other community driven ones like the Symfony one. | ||
You can **also** define your (team's) style through configuration. | ||
|
||
It can modernize your code (like converting the ``pow`` function to the ``**`` operator on PHP 5.6) | ||
It can modernize your code (like converting the `pow` function to the `**` operator on PHP 5.6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the change? i don't see any diff in UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
common markdown syntax for inline code is single backtick. Double backticks are only necessary when using a single backtick inside the code string.
I guess it is copy paste from https://github.com/PHP-CS-Fixer/PHP-CS-Fixer.github.io/blob/generator/index.rst?plain=1#L9, but there it is rst, not md.
@@ -54,7 +54,7 @@ For more details and other installation methods (also with Docker or behind CI), | |||
Assuming you installed PHP CS Fixer as instructed above, you can run the | |||
following command to fix the PHP files in the `src` directory: | |||
|
|||
```console | |||
```sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please apply same for CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
direction is good, please see my comments and self-merge when you decide it's ready
README.md
README.md
and CONTRIBUTING.md
No description provided.