Skip to content

Conversation

gharlan
Copy link
Member

@gharlan gharlan commented Aug 24, 2025

No description provided.

@@ -27,7 +27,7 @@ projects. This tool does not only detect them, but also fixes them for you.
* PHP 8.3
* PHP 8.4

> **Note**
> [!NOTE]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left is old style, right is new style:

Image

@@ -40,7 +40,7 @@ projects. This tool does not only detect them, but also fixes them for you.

The recommended way to install PHP CS Fixer is to use [Composer](https://getcomposer.org/download/):

```console
```sh
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left is old style, right is new style:

Image

@coveralls
Copy link

coveralls commented Aug 24, 2025

Coverage Status

coverage: 94.694%. remained the same
when pulling b048919 on gharlan:readme
into 0e567ee on PHP-CS-Fixer:master.

or other community driven ones like the Symfony one.
You can **also** define your (team's) style through configuration.

It can modernize your code (like converting the ``pow`` function to the ``**`` operator on PHP 5.6)
It can modernize your code (like converting the `pow` function to the `**` operator on PHP 5.6)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the change? i don't see any diff in UI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common markdown syntax for inline code is single backtick. Double backticks are only necessary when using a single backtick inside the code string.

I guess it is copy paste from https://github.com/PHP-CS-Fixer/PHP-CS-Fixer.github.io/blob/generator/index.rst?plain=1#L9, but there it is rst, not md.

@@ -54,7 +54,7 @@ For more details and other installation methods (also with Docker or behind CI),
Assuming you installed PHP CS Fixer as instructed above, you can run the
following command to fix the PHP files in the `src` directory:

```console
```sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please apply same for CONTRIBUTING.md

Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

direction is good, please see my comments and self-merge when you decide it's ready

@gharlan gharlan changed the title docs: update README.md docs: update README.md and CONTRIBUTING.md Sep 1, 2025
@gharlan gharlan enabled auto-merge (squash) September 1, 2025 17:44
@gharlan gharlan merged commit 9dfded1 into PHP-CS-Fixer:master Sep 1, 2025
32 checks passed
@gharlan gharlan deleted the readme branch September 1, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants