CI: Re-enable Paraunit in CI under PHP 8.5 #8964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keradus as you can see, there are no longer false abnormal terminations detected with my fix 🎉 As for other failures, it's either because I dropped the constraint for Paraunit 1.x or (I think) it's because there's still the issue coming from php/php-src#19507 Feel free to hijack this PR to do further testing, I'll see if I can release my fix as a patch in the coming days. |
|
looks promising. let's recover v1 possibility after no need to use dev-master. |
3bf12a6 to
5619343
Compare
…-CS-Fixer#8933)" This reverts commit 6ad0706.
5619343 to
86f2c4d
Compare
|
With Paraunit 2.7.0 all seems good 😄 @keradus up to you if you want to cleanup the |
keradus
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test PR to see if facile-it/paraunit#330 is fixed, as opposed of what went down in #8933, which was later reported as facile-it/paraunit#326.