chore: PHPUnit - enforce no memory_limit #8940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on recommendations in sebastianbergmann/phpunit#6297
kubawerlos
reviewed
Aug 15, 2025
| @@ -53,7 +53,7 @@ | |||
|
|
|||
| <php> | |||
| <ini name="zend.enable_gc" value="0"/> | |||
| <ini name="memory_limit" value="10G"/> | |||
| <ini name="memory_limit" value="-1"/> | |||
There was a problem hiding this comment.
Why do it with half-measures if we can have it directly in PHP config?
There was a problem hiding this comment.
feel free to do it for CI (like your other PR).
i still need to have it in per-project config, without changing global settings of PHP on my local machine.
There was a problem hiding this comment.
i decided to merge this PR as is.
I understand you would prefer to do it differently. it's too minor topic to waste effort on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on recommendations in sebastianbergmann/phpunit#6297