deps: remove php-cs-fixer/accessible-object
#8948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
php-cs-fixer/accessible-objectphp-cs-fixer/accessible-object
|
it's our own namespace, we can easily upgrade that lib to what we prefer. happy to hear more Heroes |
gharlan
reviewed
Aug 18, 2025
| foreach (AccessibleObject::create($transformers)->items as $transformer) { | ||
|
|
||
| $items = \Closure::bind( | ||
| static fn (Transformers $transformers): array => $transformers->items, |
There was a problem hiding this comment.
I think I prefer the Closure::bind approach. It is better DX.
E.g., when using "Find usages" in phpstorm for Transformers::items, it finds this place, but not the previous AccessibleObject::create($transformers)->items.
|
thank you @kubawerlos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php-cs-fixer/accessible-objectis usingReflectionClass::setAccessibleReflectionClass::setAccessiblewill be deprecated in PHP 8.5vendor/bin/phpunit --check-php-configuration#8934