chore: @phpstan-ignore for php version check
#8920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Aug 8, 2025
| @@ -35,6 +35,7 @@ set_error_handler(static function (int $severity, string $message, string $file, | |||
| exit(1); | |||
| } | |||
|
|
|||
| // @phpstan-ignore smaller.alwaysFalse | |||
There was a problem hiding this comment.
is it possible to add a comment why we put this ignore, in-code ? so john doe won't wonder
keradus
reviewed
Aug 11, 2025
php-cs-fixer
Outdated
| @@ -35,7 +35,7 @@ set_error_handler(static function (int $severity, string $message, string $file, | |||
| exit(1); | |||
| } | |||
|
|
|||
| // @phpstan-ignore smaller.alwaysFalse | |||
| // @phpstan-ignore smaller.alwaysFalse (PHPStan knows ower min PHP version, but we want to check the min version here anyway) | |||
There was a problem hiding this comment.
version here because entrypoint file allows wider PHP range than project itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baseline entries are "todos", but this is not really fixable. So I suggest to use
@phpstan-ignorehere.