chore: extract token types for PHPStan #8925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
150556b to
f3eb691
Compare
This was referenced Aug 13, 2025
gharlan
reviewed
Aug 13, 2025
This reverts commit 2452f84.
gharlan
reviewed
Aug 15, 2025
| @@ -220,7 +222,7 @@ private function moveMethodElement(array $elements, string $nameKeep, string $na | |||
|
|
|||
| /** | |||
| * @return list<array{ | |||
| * array{int, string}, | |||
| * _PhpTokenArray, | |||
There was a problem hiding this comment.
This is not a token array, it is a tuple of an index and a name.
| @@ -256,7 +258,7 @@ private function getDataProvidersWithUsagePairs(Tokens $tokens, int $startIndex, | |||
|
|
|||
| /** | |||
| * @param list<array{ | |||
| * array{int, string}, | |||
| * _PhpTokenArray, | |||
| @@ -98,7 +101,7 @@ public function testGetContent(int $index, string $content): void | |||
| } | |||
|
|
|||
| /** | |||
| * @return iterable<int, array{int, string}> | |||
| * @return iterable<int, _PhpTokenArray> | |||
| @@ -161,7 +164,7 @@ public function testGetTag(int $index, string $tag): void | |||
| } | |||
|
|
|||
| /** | |||
| * @return iterable<int, array{int, string}> | |||
| * @return iterable<int, _PhpTokenArray> | |||
There was a problem hiding this comment.
@gharlan , feel free to simply send a PR, if possible.
| @@ -140,7 +143,7 @@ public function testStartOrEndPos(int $pos, string $content): void | |||
| } | |||
|
|
|||
| /** | |||
| * @return iterable<int, array{int, string}> | |||
| * @return iterable<int, _PhpTokenArray> | |||
| @@ -1171,7 +1174,7 @@ private static function makeLongArrayShapeType(): string | |||
| /** | |||
| * Return type is recursive. | |||
| * | |||
| * @return list<array{int, string}|list<mixed>> | |||
| * @return list<_PhpTokenArray|list<mixed>> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #8242