Skip to content

fix: PhpdocLineSpanFixer - handle promoted properties #8897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2025
Merged

fix: PhpdocLineSpanFixer - handle promoted properties #8897

merged 1 commit into from
Jul 27, 2025

Conversation

gharlan
Copy link
Member

@gharlan gharlan commented Jul 27, 2025

When using the config ['property' => 'single'], I would expect that promoted properties are also handled:

class Foo
{
    public function __construct(
        /**
         * @var string[]
         */
        private array $foo1,

        /**
         * @var string[]
         */
        private array $foo2,
    ) {}
}

@coveralls
Copy link

Coverage Status

coverage: 94.755% (-0.006%) from 94.761%
when pulling 0e598eb on gharlan:phpdoclinespanfixer-cpp
into a955607 on PHP-CS-Fixer:master.

kubawerlos
kubawerlos approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@kubawerlos kubawerlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@kubawerlos kubawerlos merged commit 6afc55b into PHP-CS-Fixer:master Jul 27, 2025
32 checks passed
@gharlan gharlan deleted the phpdoclinespanfixer-cpp branch July 27, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubawerlos kubawerlos kubawerlos approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gharlan @coveralls @kubawerlos