fix: PhpUnitDataProviderNameFixer - fix for multiple providers defined by attributes for one test method
#8849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned by attributes for one test method
keradus
reviewed
Jul 16, 2025
| @@ -509,5 +509,39 @@ public function the_provider_of_the_data(): iterable {} | |||
| } | |||
| PHP, | |||
| ]; | |||
|
|
|||
| yield 'multiple data providers defined by attributes for one test method' => [ | |||
| <<<'PHP' | |||
There was a problem hiding this comment.
so the idea is to skip the code when multi-attributes?
or we shall have test case with expected+input code snippets ?
There was a problem hiding this comment.
so the idea is to skip the code when multi-attributes?
Always was, when we supported only PHPDocs, the if I've removed in b0aed9d was enough.
When we support attributes, we have to calculate if the relations are 1-1 between the test method and data provider, and only then fix the name.
|
Thank you for looking into this ❤ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8839