chore: FullyQualifiedStrictTypesFixer - reduce function calls
#8834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gharlan
commented
Jul 11, 2025
| ++$openedCurlyBrackets; | ||
| } if ($tokens[$index]->equals('}')) { | ||
| } elseif ($token->equals('}')) { |
| } elseif ($tokens[$index]->isGivenKind([T_INSTANCEOF, T_NEW, CT::T_USE_TRAIT, CT::T_TYPE_COLON])) { | ||
| $this->fixNextName($tokens, $index, $uses, $namespaceName); | ||
| } elseif ($tokens[$index]->isGivenKind(T_VARIABLE)) { | ||
| } elseif ($token->isGivenKind(T_VARIABLE)) { |
There was a problem hiding this comment.
elseif checks reordered..
In most files there are many more T_VARIABLE tokens than T_CLASS etc. So it makes sense to check T_VARIABLE first.
Before the change for every variable all the other isGivenKind checks were done. This is the reason for the reduced function calls.
keradus
reviewed
Jul 11, 2025
keradus
reviewed
Jul 12, 2025
| $typeStartIndex = $index; | ||
| if (null === $typeEndIndex) { | ||
| $typeEndIndex = $index; | ||
| } | ||
| } else { | ||
| if (null !== $typeEndIndex) { | ||
| $index += $this->shortenClassIfPossible($tokens, $typeStartIndex, $typeEndIndex, $uses, $namespaceName); | ||
| $this->shortenClassIfPossible($tokens, $typeStartIndex, $typeEndIndex, $uses, $namespaceName); |
There was a problem hiding this comment.
why not fast-forward the index anymore ?
There was a problem hiding this comment.
It is not used here. After the if the break finishes the foreach loop and the function ends.
There was a problem hiding this comment.
makes sense 👍🏻
(pssst, consider to have dedicated commit with commit-log describing that, you would avoid such question during review ;) )
keradus
approved these changes
Jul 12, 2025
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blackfire comparison for running the fixer on this repo with config: