Skip to content

Use "build" instead of setup.py + add "[cd build]" build trigger word #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 13, 2024
Merged

Use "build" instead of setup.py + add "[cd build]" build trigger word #994

merged 4 commits into from
Nov 13, 2024

Conversation

bact
Copy link
Member

@bact bact commented Nov 13, 2024 •
edited
Loading

python setup.py and the use of setup.py as a command line tool are deprecated.

This PR replace python setup.py sdist bdist_wheel with python -m build, as recommended in https://packaging.python.org/en/latest/discussions/setup-py-deprecated/

  • Also remove setuptools and wheel dependencies
  • Also add a wheel build trigger. If want to test the build process, just add "[cd build]" to the commit message

@bact
Use "build" instead of setup.py
ff6287f 
setup.py is now discourage.

Also remove setuptools and wheel dependencies
@bact bact added the infrastructure build process, configuration, GitHub Actions label Nov 13, 2024
@coveralls
Copy link

coveralls commented Nov 13, 2024 •
edited
Loading

Coverage Status

coverage: 52.154% (+0.05%) from 52.102%
when pulling f3190e1 on bact:build-using-cibuildwheel
into 3b26823 on PyThaiNLP:dev.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bact bact changed the title Use "build" instead of setup.py Use "build" instead of setup.py + add "[cd build]" build trigger word Nov 13, 2024
@bact
Copy link
Member Author

bact commented Nov 13, 2024

Will merge. Trigger works.

The failed test is from the time out of ConceptNet connection.

@bact bact merged commit 630b355 into PyThaiNLP:dev Nov 13, 2024
26 of 28 checks passed
@bact bact deleted the build-using-cibuildwheel branch November 13, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
infrastructure build process, configuration, GitHub Actions
Projects
PyThaiNLP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bact @coveralls