Skip to content

Conversation

bact
Copy link
Member

@bact bact commented Nov 3, 2024

The check should be if not success not if bool is False which will always False.

@bact bact added the bug bugs in the library label Nov 3, 2024
@bact bact merged commit ef4b703 into PyThaiNLP:dev Nov 3, 2024
19 of 20 checks passed
@bact bact deleted the fix-nlpo3-bool-bug branch November 3, 2024 19:36
Copy link

sonarqubecloud bot commented Nov 3, 2024

@bact bact changed the title Fix success check in nlpo3.load_dict Fix nlpo3.load_dict() that never print error msg when not success Nov 3, 2024
@bact bact mentioned this pull request Nov 3, 2024
@coveralls
Copy link

Coverage Status

coverage: 51.837% (-0.05%) from 51.89%
when pulling 26082f7 on bact:fix-nlpo3-bool-bug
into ed83a18 on PyThaiNLP:dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs in the library
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants