Better PEP 639 support from uv implementation #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e702714 to
404d0d3
Compare
konstin
commented
Jun 10, 2025
| @@ -7,12 +7,26 @@ use thiserror::Error; | |||
| pub enum Pep639GlobError { | |||
There was a problem hiding this comment.
We should start to hide the details of the error type since it's technically a breaking change, but for now we shouldn't have any users affected by this.
404d0d3 to
b8bbe1f
Compare
Since writing the initial implementation, the uv implementation got some improvements, which I'm merging back.
b8bbe1f to
0d14e73
Compare
konstin
added a commit
to PyO3/maturin
that referenced
this pull request
Jun 10, 2025
This PR adds full PEP 639 support, building upon PyO3/pyproject-toml-rs#32 and the experience in uv.
konstin
added a commit
to PyO3/maturin
that referenced
this pull request
Jun 10, 2025
This PR adds full PEP 639 support, building upon PyO3/pyproject-toml-rs#32 and the experience in uv.
konstin
added a commit
to PyO3/maturin
that referenced
this pull request
Jun 11, 2025
This PR adds full PEP 639 support, building upon PyO3/pyproject-toml-rs#32 and the experience in uv.
messense
pushed a commit
to PyO3/maturin
that referenced
this pull request
Jun 11, 2025
This PR adds full PEP 639 support, building upon PyO3/pyproject-toml-rs#32 and the experience in uv. Closes #2571 Closes #2531 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since writing the initial implementation, the uv implementation got some improvements, which I'm merging back.