Skip to content

fixes #1894 -- when the abi3 feature is set with no explicit version, use the current python interpreter's version #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

alex
Copy link
Contributor

@alex alex commented May 12, 2025

No description provided.

…ion, use the current python interpreter's version
@alex alex force-pushed the abi3-current-python branch from c4d2c06 to fac8577 Compare May 12, 2025 17:10
@messense messense self-requested a review May 13, 2025 01:41
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, I'm just a bit worried that this can be considered as a breaking change which can't be released in a 1.x version.

@alex
Copy link
Contributor Author

alex commented May 13, 2025

IMO, since this changes from a hard error to something else, I don't think it could break any users (who would be relying on something failing :-)).

@messense
Copy link
Member

I agree, let's move on and release a new version to also fix #2599

@messense messense merged commit 4e3f3a3 into PyO3:main May 13, 2025
42 checks passed
@alex
Copy link
Contributor Author

alex commented May 13, 2025

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants