Type target triple to fix regression. #2589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2562 introduced a regression breaking publishing maturin (https://github.com/PyO3/maturin/actions/runs/14923136319/job/41923286669). This PR moves the target triple type from a String to an enum, forcing all consumers to handle the virtual universal2 target themselves. I tested this as far as possible on Linux, but it's missing real macOS testing (there are two different error messages for universal2 build before and after the regression and it's now back to the "good" error message).
konstin
added a commit
that referenced
this pull request
May 9, 2025
Merged
konstin
added a commit
that referenced
this pull request
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2562 introduced a regression breaking publishing maturin (https://github.com/PyO3/maturin/actions/runs/14923136319/job/41923286669). This PR moves the target triple type from a String to an enum, forcing all consumers to handle the virtual universal2 target themselves.
I tested this as far as possible on Linux, but it's missing real macOS testing (there are two different error messages for universal2 build before and after the regression and it's now back to the "good" error message).