Revamp license handling to be compliant with PEP 639 #2571
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2025
lobsterkatie
added a commit
to getsentry/ophio
that referenced
this pull request
Apr 30, 2025
Pypi expects us to declare the license file according to PEP 639[1], but maturin doesn't yet support it[2]. Another maturin user posted a workaround[3], to try to get maturin to include the license file in the tarball, which this PR implements. (There is a draft PR[4] in the maturin repo to add support for PEP 639, but as of now it seems incomplete. If/when that's completed, merged, and released, we can update maturin and then fix the license specification as is done in #80.) [1] https://peps.python.org/pep-0639/ [2] PyO3/maturin#2531 (comment) [3] PyO3/maturin#2531 (comment) [4] PyO3/maturin#2571
messense
pushed a commit
that referenced
this pull request
Jun 11, 2025
This PR adds full PEP 639 support, building upon PyO3/pyproject-toml-rs#32 and the experience in uv. Closes #2571 Closes #2531 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://peps.python.org/pep-0639/
Closes #2531