Skip to content

Conversation

kulikjak
Copy link
Contributor

This fixes platform tag on Solaris/Illumos.

The problem is that os here can never be sunos, but rather solaris/illumos.

The following:

-                if os.starts_with("sunos") {
+                if os.starts_with("illumos") || os.starts_with("solaris") {

works as well, but checking the enum values seems nicer (and it's definitely faster). Using get_python_os would likely work as well, but I didn't go that way for the same reason.

@messense messense merged commit 862d8fb into PyO3:main Feb 23, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants