Make maturin develop fail if version info is missing in pyproject.toml
#2418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
amorenoz
added a commit
to amorenoz/retis
that referenced
this pull request
Jul 2, 2025
According to the schema of `pyproject.toml` [1] `project.version` must be specified or marked as dynamic. Maturin has started to nag (making "develop" fail) [2][3][4] if it's not the case. Since maturin gets the version from Cargo.toml anyway, mark it as dynamic. [1] https://json.schemastore.org/pyproject.json [2] PyO3/maturin#2417 [3] PyO3/maturin#2416 [4] PyO3/maturin#2418 Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
amorenoz
added a commit
to amorenoz/retis
that referenced
this pull request
Jul 11, 2025
According to the schema of `pyproject.toml` [1] `project.version` must be specified or marked as dynamic. Maturin has started to nag [2][3][4] if it's not the case, making "maturin develop" executions fail. Since maturin gets the version from Cargo.toml anyway, mark it as dynamic. [1] https://json.schemastore.org/pyproject.json [2] PyO3/maturin#2417 [3] PyO3/maturin#2416 [4] PyO3/maturin#2418 Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
amorenoz
added a commit
to amorenoz/retis
that referenced
this pull request
Jul 11, 2025
According to the schema of `pyproject.toml` [1] `project.version` must be specified or marked as dynamic. Maturin has started to nag [2][3][4] if it's not the case, making "maturin develop" executions fail. Since maturin gets the version from Cargo.toml anyway, mark it as dynamic. [1] https://json.schemastore.org/pyproject.json [2] PyO3/maturin#2417 [3] PyO3/maturin#2416 [4] PyO3/maturin#2418 Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes discussed in #2416 (comment) on top of #2417. Got this done faster than expected this morning, but won't have any time to incorporate feedback for the next ~ two days. Feel free to pull this in and butcher it any way you like. :)
Thanks again for your fantastic work on maturin! 🍰