Skip to content

Add tests demonstrating common use of TYPE_CHECKING guards #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2020
Merged

Add tests demonstrating common use of TYPE_CHECKING guards #531

merged 2 commits into from
Apr 27, 2020

Conversation

asottile
Copy link
Member

No description provided.

@asottile asottile mentioned this pull request Apr 15, 2020
Closed
PetterS
PetterS approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@PetterS PetterS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these are useful.

@asottile asottile merged commit da385d5 into PyCQA:master Apr 27, 2020
@asottile asottile deleted the test_for_common_type_checking_idiom branch April 27, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@PetterS PetterS PetterS approved these changes

@bluetech bluetech bluetech approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asottile @PetterS @bluetech