Skip to content

Add case for global exec #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 8, 2022
Merged

Add case for global exec #570

merged 16 commits into from
Jul 8, 2022

Conversation

tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Jan 31, 2020 •
edited by ericwb
Loading

Updates the general_bad_file_permissions plugin to give:

  • Medium if group writable or executable
  • High if global writable or executable

Closes #569

@tonybaloney tonybaloney mentioned this pull request Feb 26, 2020
Closed
@lukehinds
Copy link
Member

lukehinds commented Mar 6, 2020 •
edited
Loading

hey @tonybaloney

we also need to add the new stat values you added into the example file bandit/examples/os-chmod-py3.py

for example..

>> Issue: [B103:set_bad_file_permissions] Chmod setting a permissive mask 0o777 on file (/etc/hosts).
   Severity: High   Confidence: High
   Location: /home/luke/repos/bandit/examples/os-chmod-py3.py:14
   More Info: https://bandit.readthedocs.io/en/latest/plugins/b103_set_bad_file_permissions.html
14	os.chmod('/etc/hosts', 0o777)

@tonybaloney
Copy link
Contributor Author

@lukehinds sorry I fell asleep on this one! Updated

@ericwb
Copy link
Member

ericwb commented Mar 29, 2022

@tonybaloney I approved, wanna rebase and resolve the conflicts.

ericwb
ericwb reviewed Jul 8, 2022
View reviewed changes
ericwb
ericwb reviewed Jul 8, 2022
View reviewed changes
@ericwb ericwb merged commit 5809d1b into PyCQA:main Jul 8, 2022
@tonybaloney tonybaloney deleted the perms branch July 8, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwb ericwb ericwb approved these changes

@lukehinds lukehinds Awaiting requested review from lukehinds lukehinds is a code owner

@sigmavirus24 sigmavirus24 Awaiting requested review from sigmavirus24 sigmavirus24 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

general_bad_file_permissions permits most dangerous flag
3 participants
@tonybaloney @lukehinds @ericwb