Fix traceback from trojansource plugin #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trojansource plugin functions differently where it doesn't process a file by AST node. It instead does a line by line search for suspicious characters. As a result, it can't rely on the linerange being automatically set based on values fetched from the node. So it needs to set the linerange manually. Fixes: PyCQA#1246 Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com>
sigmavirus24
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trojansource plugin functions differently where it doesn't process a file by AST node. It instead does a line by line search for suspicious characters.
As a result, it can't rely on the linerange being automatically set based on values fetched from the node. So it needs to set the linerange manually.
Fixes: #1246