Skip to content

Conversation

abatilo
Copy link
Contributor

@abatilo abatilo commented Mar 1, 2023

OpenAI made an official ChatGPT API endpoint:
https://openai.com/blog/introducing-chatgpt-and-whisper-apis

The implementation here is modeled after the existing Completion
function but follows the documentation and request and response formats
outlined here:
https://platform.openai.com/docs/guides/chat/introduction

OpenAI made an official ChatGPT API endpoint:
https://openai.com/blog/introducing-chatgpt-and-whisper-apis

The implementation here is modeled after the existing `Completion`
function but follows the documentation and request and response formats
outlined here:
https://platform.openai.com/docs/guides/chat/introduction
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@abatilo you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 156
- 20

56% Go (tests)
44% Go

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

@abatilo
Copy link
Contributor Author

abatilo commented Mar 1, 2023

@tylermann Please take a look!

@letschers
Copy link
Contributor

Great job @abatilo! Are you willing to implement the chat stream too?

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR for adding Chat completions to the API looks good to me. As it's fairly straightforward, I didn't notice any issues, and it does seem to follow the documentation quite well.

As an aside, I am quite interested to see how this ends up being used with PullRequest. Great to see support for the new model / endpoint being added so quickly.

Image of Ryan B Ryan B


Reviewed with ❤️ by PullRequest

@abatilo
Copy link
Contributor Author

abatilo commented Mar 2, 2023

Great job @abatilo! Are you willing to implement the chat stream too?

Looks like we had someone take care of it in #31 stacked on top of this PR

@bakks
Copy link
Contributor

bakks commented Mar 2, 2023

@abatilo Want to merge this PR in first? Or shall we close this one and do mine? Happy either way

@abatilo
Copy link
Contributor Author

abatilo commented Mar 2, 2023

@bakks I don't have any ability to merge this PR. If yours was already approved and mergeable, let's go ahead and merge yours!

@bakks
Copy link
Contributor

bakks commented Mar 3, 2023

Oh, I guess I can't either, hah - will wait then

Copy link
Contributor

@tylermann tylermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @abatilo , sorry for the delay here I have been away from my computer this week. The changes here look good to me and fairly isolated so should be good to merge in.

@tylermann tylermann merged commit 8543706 into PullRequestInc:main Mar 3, 2023
@abatilo
Copy link
Contributor Author

abatilo commented Mar 3, 2023

Thank you much @tylermann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants