Skip to content

Updated go.mod dependencies per Snyk alert #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Updated go.mod dependencies per Snyk alert #404

merged 1 commit into from
Jan 4, 2022

Conversation

jauderho
Copy link
Contributor

@jauderho jauderho commented Jan 4, 2022

Signed-off-by: Jauder Ho jauderho@users.noreply.github.com

Snyk identified goquery as needing to have an updated golang.org/x/net/http2. See https://security.snyk.io/vuln/SNYK-GOLANG-GOLANGORGXNETHTTP2-2313688

This PR just bumps the x/net version.

Signed-off-by: Jauder Ho <jauderho@users.noreply.github.com>
@mna mna merged commit 8c90f82 into PuerkitoBio:master Jan 4, 2022
@mna
Copy link
Member

mna commented Jan 4, 2022

Thanks!

@mna
Copy link
Member

mna commented Jan 4, 2022

Just a note for others stumbling on this, goquery does not use the http2 package and as such was not impacted by the security alert. It only uses the golang.org/x/net/html package, but since both http2 and html are in the same repo, it probably got flagged as requiring an upgrade. No harm done either way, not a bad thing to update the deps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants