Skip to content

[Linux Pulse/Pipewire] No sink path *rebased* #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2022
Merged

[Linux Pulse/Pipewire] No sink path *rebased* #372

merged 4 commits into from
Oct 11, 2022

Conversation

Logical-sh
Copy link
Contributor

Description

This is a resubmit of PR #237 As I made a new branch just in case.
Added some logic so it should handle the case of no default audio sink.
I do not currently have a setup where there are no audio sinks to test this, and am having encoder issues on my current machine, therefore I marked this as draft until further testing can occur.

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Testing Scenarios

  • No sinks on launch (Should create and switch to virtual sink)
  • Has a sink, Uses "play audio on host"
  • Has a sink, Does not use "play audio on host"

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the base branch from master to nightly September 16, 2022 16:52
@github-actions
Copy link

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

@Logical-sh
Copy link
Contributor Author

@zb140
Can you give this one last pass?
If not I will test soon, but there were no code changes it should just be a sanity check.

@Logical-sh Logical-sh mentioned this pull request Sep 16, 2022
Closed
9 tasks
@zb140
Copy link

zb140 commented Sep 16, 2022

@Logical-sh Sure, I'd be happy to. I should be able to do it this evening after work, or if not then, I can definitely do it tomorrow.

@Logical-sh
Copy link
Contributor Author

Thanks!
Sorry it took so long to get around to!

@zb140
Copy link

zb140 commented Sep 17, 2022

Just gave it a go, and it's working great 👍

No more crash, I'm seeing the same log as before:

gow-sunshine-1  | [2022:09:17:01:15:08]: Warning: Couldn't find an active default sink. Continuing with virtual audio only.

so we can be confident it's going through the right code path. Thanks all (and particularly @Logical-sh)!

@Logical-sh Logical-sh marked this pull request as ready for review September 17, 2022 06:43
@zb140 zb140 mentioned this pull request Sep 25, 2022
Closed
@ReenigneArcher
Copy link
Member

@Logical-sh do you think we're good to merge based on the testing by @zb140 ? I don't have the ability to test your scenarios at the moment.

@Logical-sh
Copy link
Contributor Author

I think so, the rebase was painless. And it was test more before that, so I'd say go for it.

@ReenigneArcher ReenigneArcher merged commit f51a84c into LizardByte:nightly Oct 11, 2022
This was referenced Oct 11, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash in PulseAudio init on connecting
4 participants
@Logical-sh @CLAassistant @zb140 @ReenigneArcher