Skip to content

fix path issues #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 12, 2022
Merged

fix path issues #330

merged 17 commits into from
Sep 12, 2022

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Aug 12, 2022 •
edited
Loading

Description

  • move default config and apps files to assets directory
  • create appdir if it doesn't exist
  • remove backup and restore of config files
  • remove portable home and config directories for AppImage
  • add service install and uninstall scripts back to Windows packages
  • automatically add and remove windows service (if service component is selected at install)
  • automatically add and remove firewall rules (if firewall component is selected at install)
  • delete start menu entry upon uninstall (Windows only)
  • delete program install directory upon uninstall, with user prompt (Windows only)

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher changed the title move default configs to assets directory fix path issues Aug 12, 2022
@ReenigneArcher ReenigneArcher force-pushed the fix/paths branch 22 times, most recently from 99490b6 to 49ceb14 Compare August 14, 2022 19:46
@ReenigneArcher ReenigneArcher mentioned this pull request Aug 14, 2022
Closed
@ReenigneArcher ReenigneArcher mentioned this pull request Aug 14, 2022
Merged
5 tasks
@ReenigneArcher
single AppImage file
8b0e6a2 
- simplify cmake install prefix and assets directory
@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Aug 17, 2022 •
edited
Loading

@sitiom would you be able to test the windows package please, from this PR build?

  • scripts present
  • service automatically added upon install
  • service automatically removed upon uninstall
  • firewall rule automatically added upon install
  • firewall rule automatically removed upon uninstall

@sitiom

This comment was marked as outdated.

Sign in to view
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
@ReenigneArcher
fix windows install extra commands and...
6980ee3 
- prompt to remove install directory on uninstall
- delete start menu icons on uninstall
- create appdata folder if it doesn't exist
@ReenigneArcher ReenigneArcher marked this pull request as ready for review August 21, 2022 03:26
@ReenigneArcher ReenigneArcher mentioned this pull request Aug 24, 2022
Closed
@ReenigneArcher
update docs
43fa410 
- add information about various ports
- correct typos in macos installation instructions
@sitiom

This comment was marked as resolved.

Sign in to view
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
sitiom
sitiom previously approved these changes Aug 30, 2022
View reviewed changes
@ReenigneArcher ReenigneArcher merged commit 636a928 into nightly Sep 12, 2022
@ReenigneArcher ReenigneArcher deleted the fix/paths branch September 12, 2022 00:28
@ReenigneArcher ReenigneArcher mentioned this pull request Sep 12, 2022
Merged
5 tasks
@ReenigneArcher ReenigneArcher mentioned this pull request Oct 16, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sitiom sitiom sitiom left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReenigneArcher @sitiom