Skip to content

ci: build all before releasing #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ci: build all before releasing #319

wants to merge 1 commit into from

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Aug 10, 2022

Description

Upon creating a new release, all binaries should be available. This should fix https://github.com/LizardByte/Sunshine/discussions/318#discussioncomment-3362357

The https://github.com/softprops/action-gh-release action is used for releasing and the action from this org is no longer used as the action is only run once and not reused elsewhere.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring/documentation-blocks for new or existing methods/components

@github-actions github-actions bot changed the base branch from master to nightly August 10, 2022 12:09
@github-actions
Copy link

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

@ReenigneArcher
Copy link
Member

This does not resolve the issue at hand. The winget workflow is failing even with the .exe present.

@sitiom
Copy link
Contributor Author

sitiom commented Aug 10, 2022 •
edited
Loading

This does not resolve the issue at hand. The winget workflow is failing even with the .exe present.

Which shouldn't, and should be a bug in the action if it does so. Perhaps reruns do not work. cc @vedantmgoyal2009

But anyways, this fixes the case where the .exe is not present (which happened on the first run).

@vedantmgoyal9
Copy link

On re-runs, the release object in the GitHub context payload does not get updated, and hence, the action can't find .exe URL.

@sitiom
Copy link
Contributor Author

sitiom commented Aug 10, 2022

On re-runs, the release object in the GitHub context payload does not get updated, and hence, the action can't find .exe URL.

Oh alright, that explains it. @ReenigneArcher Should I make a manual update to winget-pkgs for 0.14.1 for a while?

@ReenigneArcher
Copy link
Member

On re-runs, the release object in the GitHub context payload does not get updated, and hence, the action can't find .exe URL.

Oh alright, that explains it. @ReenigneArcher Should I make a manual update to winget-pkgs for 0.14.1 for a while?

Yes, for now. I don't plan to create another release just to update winget-pkgs.

@sitiom
Copy link
Contributor Author

sitiom commented Aug 10, 2022

Ok. microsoft/winget-pkgs#69256

@ReenigneArcher ReenigneArcher mentioned this pull request Oct 28, 2022
Merged
7 tasks
@sitiom sitiom deleted the gh-actions branch October 29, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sitiom @ReenigneArcher @vedantmgoyal9