Skip to content

[Linux Pulse/Pipewire] No sink path #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Linux Pulse/Pipewire] No sink path #237

wants to merge 2 commits into from

Conversation

Logical-sh
Copy link
Contributor

Description

Added some logic so it should handle the case of no default audio sink.
I do not currently have a setup where there are no audio sinks to test this, and am having encoder issues on my current machine, therefore I marked this as draft until further testing can occur.

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Testing Scenarios

  • No sinks on launch (Should create and switch to virtual sink)
  • Has a sink, Uses "play audio on host"
  • Has a sink, Does not use "play audio on host"

@zb140
Copy link

zb140 commented Jul 30, 2022

I would really like to see this get merged :-) I'm available to help testing the "no sinks on launch" case if it helps.

@ReenigneArcher
Copy link
Member

I would really like to see this get merged :-) I'm available to help testing the "no sinks on launch" case if it helps.

This PR is still in a draft state. Once it's marked ready we can build this version to test.

@zb140
Copy link

zb140 commented Aug 10, 2022

Per @ABeltramo's request, I've tested this branch on my setup with no sinks, and it works perfectly. As expected, I see this in the logs when I connect:

gow-sunshine-1  | [2022:08:10:17:46:24]: Warning: Couldn't find an active default sink. Continuing with virtual audio only.

So we know it's going through the correct code path. After connecting, audio plays back correctly with no issues. Thanks @Logical-sh !

@ReenigneArcher
Copy link
Member

@zb140 thank you for testing!

@Logical-sh is it possible for you to update your branch with our latest changes? I believe the main thing that changed is the directory of those files changed from sunshine to src. We also now require that branches are up to date before merging (since I learned about branch protection rules).

@Sparticuz
Copy link

Is there something blocking the rebase?

@Logical-sh
Copy link
Contributor Author

Logical-sh commented Aug 29, 2022 via email

@Logical-sh Logical-sh mentioned this pull request Sep 16, 2022
Merged
9 tasks
@Logical-sh
Copy link
Contributor Author

Closing in favor of #372.

@Logical-sh Logical-sh closed this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Logical-sh @zb140 @ReenigneArcher @Sparticuz