package/linux: Provide launchable tags in appstream metainfo file #2006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the .desktop file gets installed to sunshine.desktop, as such provide the launchable tag for it to help `appstream-builder` "find" the .desktop file due to the id (Sunshine.desktop) not matching. Rename the id to just @PRODUCT_NAME@ as well since the .desktop suffix is no longer required. Provide URL as well. Spec: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable Fixes appstream-builder generation for this package in Solus.
|
|
|
You may wish to double check this change with flatpak-builder if this file is referenced by that. |
| @@ -11,6 +11,8 @@ | |||
| @PROJECT_LONG_DESCRIPTION@ | |||
| </p> | |||
| </description> | |||
| <launchable type="desktop-id">sunshine.desktop</launchable> | |||
There was a problem hiding this comment.
How will this work with the multiple desktop files?
We provide 2 for normal cases. 2 for Flatpak (X11 versus KMS).
|
Closing due to no response. Happy to re-open if there is communication. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default the .desktop file gets installed to sunshine.desktop, as such provide the launchable tag for it to help
appstream-builder"find" the .desktop file due to the id (Sunshine.desktop) not matching.Rename the id to just @PRODUCT_NAME@ as well since the .desktop suffix is no longer required.
Provide URL as well.
Spec: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable
Fixes appstream-builder generation for this package in Solus.
Screenshot
N/A
Issues Fixed or Closed
N/A
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.