Skip to content

Fix system tray Open Sunshine #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2023
Merged

Fix system tray Open Sunshine #1095

merged 3 commits into from
Mar 28, 2023

Conversation

KuleRucket
Copy link
Contributor

@KuleRucket KuleRucket commented Mar 28, 2023 •
edited
Loading

Description

In Linux, the action to Open Sunshine in the system tray did not work. The action calls "open URL", but really it should be "xdg-open URL".

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

ReenigneArcher
ReenigneArcher requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@ReenigneArcher ReenigneArcher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For macOS, it should still be "open"?

I know the tray is disable in macOS right now due to a threading issue, but still want to make it as easy as possible to implement if we find a solution to that.

KuleRucket and others added 2 commits March 29, 2023 00:12
@KuleRucket @ReenigneArcher
Update src/system_tray.cpp
d577d3c 
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@KuleRucket @ReenigneArcher
Update src/system_tray.cpp
4c6b777 
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@KuleRucket
Copy link
Contributor Author

For macOS, it should still be "open"?

I know the tray is disable in macOS right now due to a threading issue, but still want to make it as easy as possible to implement if we find a solution to that.

I'll take your word for it as I have no experience with macOS.

@ReenigneArcher ReenigneArcher merged commit 7067432 into LizardByte:nightly Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReenigneArcher ReenigneArcher ReenigneArcher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KuleRucket @ReenigneArcher @LizardByte-bot