Skip to content

Continue in the face of failure #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

KuleRucket
Copy link
Contributor

Description

Instead of exiting when one of the major components fails to initialise, this change will log errors and continue. The advantage of this is that even though sunshine will not work, the web UI will still be available to view the logs and fix configuration.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher merged commit 57a722a into LizardByte:nightly Mar 28, 2023
@Nonary

This comment was marked as spam.

@Nonary

This comment was marked as spam.

@KuleRucket
Copy link
Contributor Author

KuleRucket commented Mar 30, 2023

This broke audio for windows because it is calling the deconstructor which deallocates the COM API used for audio.

This is currently impacting stable release.

I put the guard back in on this branch. Not sure if it needs to be a new PR though

@Nonary

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants