Nightly Notification Bug Fixes #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve indexes I guess this was someone who was used to too much Python :) Also added an additional check to remove stable releases that aren't a new version
ReenigneArcher
requested changes
Mar 25, 2023
added 3 commits
March 25, 2023 14:30
This commit refactors the stableBuildAvailable() and nightlyBuildAvailable() computed properties to improve code clarity. The buildVersionIsStable() method has been renamed to isStableBuild() for better naming consistency, and the nightlyBuildAvailable() computed property has been renamed to isNightlyBuildAvailable() to more clearly indicate its purpose.
Previously, the version check was incorrectly splitting the version number string by "-g" instead of ".", resulting in an error that prevented the check from properly detecting the version. This commit fixes the bug by updating the version check to split the version number string by ".", which is the correct delimiter for version numbers
I changed the style of this boolean check to be more consistent with the other booleans
ReenigneArcher
requested changes
Mar 25, 2023
I've also changed the order of the boolean checks in the method so it doesn't short circuit and exit out early, it will check for version first.
ReenigneArcher
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a bug in the code that prevents the version update from working properly for nightly builds. The changes made in this pull request ensure that the expected behavior is met, which is to suggest a new nightly release when available, and only suggest a stable release if it has a higher version number than the nightly release.
Changes Made:
Updated the hasNewStable method to check nightly builds by comparing the latest nightly version tag with the stable version, and only returning true if the latest stable version is higher than their current nightly version. If the user does not have a nightly version of Sunshine, the existing functionality of the method remains the same.
Fixed a bug in the hasNewNightly method by using pop() instead of indexing by -1. JavaScript does not use negative indexes, so that would have returned back undefined instead of their original intended design decision, which was to retrieve the last index of the version split.
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.