Skip to content

Provide ability to force a capture method via configuration. #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 26, 2023
Merged

Provide ability to force a capture method via configuration. #1063

merged 11 commits into from
Mar 26, 2023

Conversation

KuleRucket
Copy link
Contributor

@KuleRucket KuleRucket commented Mar 24, 2023 •
edited
Loading

Description

In Linux sunshine will test nvfbc, kms, wayland and x11 capture methods and will choose the first one that works in that order. This change allows you to force a specific one as long as it is available. If no capture method is found or if you select one that cannot be initialized, then an error message will be raised.

Documentation update to follow.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@KuleRucket
Copy link
Contributor Author

KuleRucket commented Mar 24, 2023 •
edited
Loading

While making this change I came across this:

        // On Wayland, using KMS, the cursor is unreliable.
        // Hide it by default
        display_cursor = false;

I'm not sure if this is still valid.

@ReenigneArcher
Copy link
Member

This is a nice idea! I'll review in detail tomorrow.

@KuleRucket
Copy link
Contributor Author

Documentation added. I'm not sure how to test if my reference to Linux Setup is working.

ReenigneArcher

This comment was marked as resolved.

Sign in to view

@KuleRucket
Copy link
Contributor Author

I think it's all cleaned up now

ReenigneArcher
ReenigneArcher previously approved these changes Mar 25, 2023
View reviewed changes
@ReenigneArcher ReenigneArcher merged commit c6548f4 into LizardByte:nightly Mar 26, 2023
ReenigneArcher
ReenigneArcher reviewed Apr 22, 2023
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReenigneArcher ReenigneArcher ReenigneArcher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KuleRucket @ReenigneArcher @LizardByte-bot