-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add Support for Safely Elevating Administrator Privileges #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Your PR was set to |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Regarding #764, that error occurs for me when I don't use Didn't have anything to do with elevation in my experience. |
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested this, but overall the code looks good. Just have a few minor suggestions.
bf7f5a7
to
19991d2
Compare
Depends on #1022 |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
…he command using PowerShell forcing a UAC prompt.
…egardless if 740 or not
…o why a tool needs to be used Powershell is no longer a dependency
7133e1a
to
0beb940
Compare
Description
Sunshine will be able to detect if a command failed due to lack of elevation and will try again in an elevated context.
It does it in a safer manner, forcing a UAC prompt and user interaction.
As a bonus, when #998 is fixed as well, this will work for the pre-commands as well.
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.