windows: input: activate US keyboard layout for scancode mapping #975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When installed as a service, scancode mapping for non-US keyboards will not work correctly on first boot if the user's Windows installation does not have the English (US) language & keyboard installed as a fallback, and/or the installation is configured to automatically log in.
On first boot, Sunshine does not translate the international keys correctly, and modifier keys such as ctrl/alt/shift will appear stuck after first press (which can be visually confirmed via the On-Screen Keyboard application). Restarting Sunshine after the desktop session has loaded fixes mapping on subsequent connections, indicating that the US locale is loaded but isn't activated correctly in Sunshine when the desktop session is not yet loaded.
This can be fixed by invoking
ActivateKeyboardLayout()
(scoped to Sunshine's process) after loading the US locale.Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.