Skip to content

Conversation

psyke83
Copy link
Contributor

@psyke83 psyke83 commented Feb 25, 2023

Description

When installed as a service, scancode mapping for non-US keyboards will not work correctly on first boot if the user's Windows installation does not have the English (US) language & keyboard installed as a fallback, and/or the installation is configured to automatically log in.

On first boot, Sunshine does not translate the international keys correctly, and modifier keys such as ctrl/alt/shift will appear stuck after first press (which can be visually confirmed via the On-Screen Keyboard application). Restarting Sunshine after the desktop session has loaded fixes mapping on subsequent connections, indicating that the US locale is loaded but isn't activated correctly in Sunshine when the desktop session is not yet loaded.

This can be fixed by invoking ActivateKeyboardLayout() (scoped to Sunshine's process) after loading the US locale.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants