Skip to content

Conversation

briankendall
Copy link
Contributor

Description

This PR adds three new settings that allow suppressing client input from the mouse, keyboard, and gamepads, one for each type of input. They can be toggled individually, allowing any combination of allowable input the user desires. This also allows for disabling client input entirely, putting Sunshine in a "view only" mode.

All settings are disabled by default, meaning there's no change in default behavior.

This feature was suggested here: https://github.com/LizardByte/Sunshine/discussions/822

Screenshot

Screen Shot 2023-02-15 at 8 36 11 PM

Issues Fixed or Closed

N/A

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Notes: code additions are very simple and I consider them sufficiently self explanatory to not require any comments.

I have not added any new methods or components.

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the base branch from master to nightly February 16, 2023 01:45
@github-actions
Copy link

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

@briankendall briankendall force-pushed the suppress-input branch 2 times, most recently from 090f2c1 to 58aeb57 Compare February 16, 2023 01:52
Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! This will be a nice feature to add.

I would like to ask for a small adjustment though.

@ReenigneArcher ReenigneArcher merged commit f238cf5 into LizardByte:nightly Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants