Fix rumble events causing game to freeze #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull requests must be made to the |
|
You can edit the PR to change the branch to nightly |
|
Ah, sorry, I've updated it! |
…to the old vector. Decrement index for polls when erasing to make sure none of the events are skipped.
|
I can't test this (I don't have a Linux machine available), but both the code and rationale seems reasonable. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where, if a rumble event happened, the game (HITMAN 3 in my case) would freeze for around a minute or so. This happened because a previous fix (loki-47-6F-64/sunshine@1f7bdb1) copied the poll fds to a temporary vector that was used for the poll call, but the received events were never copied back to the original vector, causing it to freeze until a timeout because it expected to find a POLLIN event.
I tested this by playing HITMAN 3 and throwing a remote charge - before the fix it would freeze for a few minutes just after detonating it, but with the fix it works just fine.
Screenshot
Issues Fixed or Closed
Type of Change
Checklist