Skip to content

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Jan 27, 2023

Description

This PR contains some miscellaneous installer improvements for Windows:

  • Fixes silent mode to be truly silent (no dialogs or browser windows)
  • Switches to nsExec::ExecToLog for terminal commands and ExecShell to avoid spawning focus-stealing command prompt windows
  • Adjusted wording in ViGEmBus dialog to make it even more clear that this is required for gamepad support
  • Changes the name of the installed Sunshine shortcut to try to reduce confusion when running as a background service

Screenshot

Issues Fixed or Closed

Fixes #790

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
Copy link
Member

Any idea how to add the install directory to the PATH?

@cgutman
Copy link
Collaborator Author

cgutman commented Jan 28, 2023

Any idea how to add the install directory to the PATH?

I'm not sure, but we probably don't want to do that unconditionally. Since the best experience is Sunshine running as a service, it may be best for most systems not to clutter the PATH with our directory, since most users shouldn't launch Sunshine that way.

@cgutman cgutman merged commit 142f067 into LizardByte:nightly Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants