Skip to content

Conversation

safijari
Copy link
Contributor

Description

Reported by DemonCat on Discord. The basic auth header is printed when loglevel is Debug, which could be an issue when a user submits their logs.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@safijari safijari marked this pull request as ready for review January 25, 2023 17:43
@safijari safijari changed the title One line fix Scrub basic auth header from logs Jan 25, 2023
@KuleRucket
Copy link
Contributor

"CREDS" is not a real word

@ReenigneArcher ReenigneArcher force-pushed the scrub-auth-header-in-logs branch from 7f73792 to 7b7557f Compare January 25, 2023 23:19
@ReenigneArcher ReenigneArcher merged commit 1f2ad8d into LizardByte:nightly Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants