Fix SimpleWeb arbitrary file read vulnurability #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/confighttp.cpp
Outdated
| response->write(SimpleWeb::StatusCode::success_ok, in, headers); | ||
| else if(!isChildPath(filePath, nodeModulesPath)) { | ||
| BOOST_LOG(warning) << "Someone requested a path " << filePath << " that is outside the node_modules folder"; | ||
| response->write(SimpleWeb::StatusCode::client_error_bad_request, "Not Authorized"); |
There was a problem hiding this comment.
I would still log the attempt, but give 404 nevertheless. The attacker shouldn't know if the file exists or not
There was a problem hiding this comment.
How about a straight up 400 with no other info. We can do the 400 in the case that the path is outside the node modules even if it doesn't exist. That way there would be no way to map out the user's computer.
There was a problem hiding this comment.
Ok I've made that change in my latest commit and it seems to work as expected. Lemme know your thoughts.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for this using std::filesystem and computing relative paths.
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.