Skip to content

Add TPCircularBuffer submodule #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2022
Merged

Add TPCircularBuffer submodule #82

merged 1 commit into from
Mar 3, 2022

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Mar 2, 2022 •
edited
Loading

Description

I was trying to build sunshine on macOS when I noticed the TPCircularBuffer submodule was missing.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the documentation blocks for new or existing components

@sitiom sitiom mentioned this pull request Mar 2, 2022
Closed
5 tasks
@ReenigneArcher
Copy link
Member

@abusse pretty straightforward but figured I'd let you review.

@ReenigneArcher ReenigneArcher added bug Something isn't working dependencies Pull requests that update a dependency file os:macOS OS is macOS labels Mar 2, 2022
@ReenigneArcher ReenigneArcher merged commit 6da0483 into LizardByte:nightly Mar 3, 2022
@sitiom sitiom deleted the nightly branch March 3, 2022 16:14
@abusse
Copy link
Contributor

abusse commented Mar 5, 2022

Saw that only rn and makes me wonder how I could have missed that in my PR 🤔

@ReenigneArcher
Copy link
Member

Saw that only rn and makes me wonder how I could have missed that in my PR 🤔

No worries! I just recently learned about submodules. I originally thought you only had to update the .gitmodules file 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReenigneArcher ReenigneArcher ReenigneArcher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file os:macOS OS is macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sitiom @ReenigneArcher @abusse