All committers have signed the CLA.

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

Thank you for your submission.

Arguably we could conditionally pull ffpmeg-linux-aarch64 instead of its x86_64 counterpart when building for / on aarch64, but because arch doesn't specify aarch64 as a valid architecture for this package, there's no real need.

I was planning to enable this for aarch64, but as far as I could find all the dependencies are not available for arm64. Perhaps I am searching wrong, but when I search for avahi for example, it just shows x86_64... https://archlinux.org/packages/?sort=&q=avahi&maintainer=&flagged=

In fact, arm64/aarch64 is not even listed as a possible architecture.

Strictly speaking, Arch only supports x86_64 and so they don't list alternative architectures on the official AUR. The arch parameter in a PKGBUILD specifies which architectures the package maintainer deems it to be compatible with, but the upstream distro itself will only support/endorse/etc x86_64. aarch64 and i686 are supplied by separate projects (https://archlinuxarm.org/ and https://archlinux32.org/).

Nothing stops you from defining i686 and/or aarch64 in arch, you just forfeit any distro level support and have to take it on yourself. If we do want this package to build on aarch64, we'd need to adjust the prepare section to conditionally pull the appropriate submodule.

Strictly speaking, Arch only supports x86_64 and so they don't list alternative architectures on the official AUR. The arch parameter in a PKGBUILD specifies which architectures the package maintainer deems it to be compatible with, but the upstream distro itself will only support/endorse/etc x86_64. aarch64 and i686 are supplied by separate projects (https://archlinuxarm.org/ and https://archlinux32.org/).

Nothing stops you from defining i686 and/or aarch64 in arch, you just forfeit any distro level support and have to take it on yourself. If we do want this package to build on aarch64, we'd need to adjust the prepare section to conditionally pull the appropriate submodule.

Okay, would you mind making the adjustment, as well as adding aarch64 to the arch parameter?

@ReenigneArcher Sure, although you may want to remove i686 altogether, there only seems to be x86_64 and aarch64 ffpmeg submodules so sunshine may not build in i686 at all.

you may want to remove i686 altogether

That's fine with me as well.

You have most commands in the if/else block repeating for every branch.

All of this could simply be outside the if block:

        git -c submodule."ffmpeg-macos-x86_64".update=none \
            -c submodule."ffmpeg-windows-x86_64".update=none \
            -c submodule."ffmpeg-macos-aarch64".update=none \
            submodule update --recursive --init

@KuleRucket then it would grab non architecture specific submodules in all cases.

The final commit is OK. I was looking at the one before that had the same in the else block.