Skip to content

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Jan 21, 2023

Description

This PR contains some miscellaneous prep work for HDR support. The main changes are:

  • Plumbing the video::config_t into the display implementations to allow them to tell HDR and SDR streams apart
  • Call IDXGIFactory1::IsCurrent() each frame to tell if there has been a GPU or display change. Microsoft recommends this method of detection. It is required to accurately detect HDR transitions.
  • Implement display_t functions to return HDR state and HDR metadata
  • Configure the encoder for SMPTE ST 2084 PQ and Rec 2020 when in HDR mode
  • Send the HDR mode message to Moonlight when HDR state changes

Note: This is only prep work. HDR will not work properly with these changes alone.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@cgutman cgutman force-pushed the hdr_prep_v2 branch 3 times, most recently from 443f28f to 08c094d Compare January 23, 2023 06:59
@cgutman cgutman merged commit 9181028 into LizardByte:nightly Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant