Skip to content

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Jan 16, 2023

Description

This PR implements a new tool ddprobe.exe which Sunshine invokes to perform detection of which GPU preference value is required to get working Desktop Duplication. The GPU preference gets locked in at the moment the first DXGI factory is constructed and cannot be changed for the lifetime of the process, so we must use a sacrificial process to perform the probing rather than doing it inside Sunshine itself.

This approach seems to work both with official NVIDIA Optimus laptops (including with conflicting overrides in the NVIDIA Control Panel) and with "regular" multi-GPU systems like desktop PCs with both an iGPU and a dGPU enabled.

Screenshot

Issues Fixed or Closed

Fixes #737

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@cgutman cgutman merged commit 49fc618 into LizardByte:nightly Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant